[wp-trac] [WordPress Trac] #51665: wp_get_image_editor() ->save stopped creating the directory in 5.6-beta2-49360

[WordPress Trac]

#51665: wp_get_image_editor() ->save stopped creating the directory in
5.6-beta2-49360
-------------------------------------------------+-------------------------
 Reporter:  eemitch                              |       Owner:
                                                 |  mikeschroder
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.6
Component:  Media                                |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by mikeschroder):

 Thanks @johnbillion!

 I like the additional error reporting you added.

 I picked this spot because it best matches the logic from the previous
 code path.

 Unless we re-evaluate `make_image()` again, I'm not sure of a better place
 to put it. Current opinion is that it's fine to start here, and if a
 better place emerges later, make a change.

 If anyone else can think of a better spot, then excellent!


 Thanks for the test as well -- I'm noticing an issue when running the
 entire test suite locally. Getting a few errors, starting with:

 {{{
 ...........................................................  5664 / 11471
 ( 49%)
 ...PHP Warning:  Uncaught require_once(/srv/www/wordpress-
 develop/public_html/build/wp-content/srv/www/wordpress-
 develop/public_html/tests/phpunit/includes/../data/themedir1/custom-
 internationalized-theme/functions.php): failed to open stream: No such
 file or directory

 /srv/www/wordpress-
 develop/public_html/tests/phpunit/tests/l10n/localeSwitcher.php:444
 /srv/www/wordpress-
 develop/public_html/tests/phpunit/tests/l10n/localeSwitcher.php:444
 }}}

 If I remove the tests, it passes, and if I add back the change in
 `tests/phpunit/includes/bootstrap.php`, it fails.

 Will look into it, but thought I'd mention here in case anyone can track
 it down sooner.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51665#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform