[wp-trac] [WordPress Trac] #51425: Customizer Restore Autosave Notice dismiss function is not called
WordPress Trac
noreply at wordpress.org
Fri Nov 6 01:38:51 UTC 2020
#51425: Customizer Restore Autosave Notice dismiss function is not called
--------------------------+-----------------------------
Reporter: karthikbhatb | Owner: noisysocks
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.6
Component: Customize | Version: 5.5
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui, javascript
--------------------------+-----------------------------
Comment (by noisysocks):
Thinking about this some more, I think that it's wrong to enqueue `common`
in `customize.php`.
`common` contains JavaScript that makes common WP Admin elements
interactive: table columns, form validation, notices, screen meta, help
tabs, menu interactivity, etc. But Customize is a very unique screen that
contains essentially none of these elements.
I suspect there are other undiscovered bugs similar to this one that come
as a result of `common` trying to add functionality to the Customize
screen that isn't relevant.
At the very least, by enqueuing `common` here, we're making the browser
parse and execute ~2000 lines of unnecessary JavaScript which will
negatively affect Customize page load performance.
`deprecateL10nObject` should be moved elsewhere so that `updates` can use
it without having to depend on all of `common`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51425#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list