[wp-trac] [WordPress Trac] #51425: Customizer Restore Autosave Notice dismiss function is not called
WordPress Trac
noreply at wordpress.org
Thu Nov 5 19:58:49 UTC 2020
#51425: Customizer Restore Autosave Notice dismiss function is not called
--------------------------+-----------------------------
Reporter: karthikbhatb | Owner: noisysocks
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.6
Component: Customize | Version: 5.5
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui, javascript
--------------------------+-----------------------------
Changes (by SergeyBiryukov):
* keywords: has-patch 2nd-opinion => has-patch
Comment:
Replying to [comment:6 noisysocks]:
> The attached PR does indeed fix this error by making `common` return
early if notices have already been initialised, but I think it would be
better if we fixed the underlying issue here and made it so that notices
are only initialised once.
I agree that would be the preferred fix here.
It looks like the patch might need some adjustment, but the `common`
dependency is required, per comment:7.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51425#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list