[wp-trac] [WordPress Trac] #51612: `render_block_data` for nested blocks - WP_Block::render vs render_block
WordPress Trac
noreply at wordpress.org
Thu Nov 5 08:46:55 UTC 2020
#51612: `render_block_data` for nested blocks - WP_Block::render vs render_block
--------------------------+-----------------------------
Reporter: gaambo | Owner: (none)
Type: defect (bug) | Status: closed
Priority: normal | Milestone: Future Release
Component: Editor | Version: 5.5
Severity: normal | Resolution: invalid
Keywords: needs-patch | Focuses:
--------------------------+-----------------------------
Changes (by gaambo):
* status: new => closed
* resolution: => invalid
Comment:
Thanks for answering and adding 👍
Do you think it should be called in `WP_Block::construct` or
`WP_Block::render`?
I think `render` makes a little more sense, that would mean extracting
this filters from `render_block` - which makes this function very thin.
Would that be okay? Gotta admit I'm a little overwhelmed with this
function and all the context stuff happing, so can't really help with a
patch here, but can help with testing.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51612#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list