[wp-trac] [WordPress Trac] #25473: wp_text_diff creates wrong number of columns if title arguments are set
WordPress Trac
noreply at wordpress.org
Tue Nov 3 22:03:35 UTC 2020
#25473: wp_text_diff creates wrong number of columns if title arguments are set
-------------------------------------------------+-------------------------
Reporter: joedolson | Owner:
| adamsilverstein
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.7
Component: Revisions | Version: 3.6.1
Severity: normal | Resolution:
Keywords: has-patch needs-design-feedback | Focuses:
needs-design needs-screenshots | accessibility
-------------------------------------------------+-------------------------
Changes (by adamsilverstein):
* milestone: Future Release => 5.7
Comment:
After reviewing this again with @paaljoachim I think the best thing would
be to apply the simplest solution possible, such as that suggested in
https://core.trac.wordpress.org/attachment/ticket/25473/markup-table.diff
This fixes the original error reported in the ticket ("wp_text_diff
creates wrong number of columns if title arguments are set") without
growing the scope. I'd love to see a revisions feature re-imagined for the
block editor and include lessons we have learned here. I'll mark this for
5.7 and do more testing.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/25473#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list