[wp-trac] [WordPress Trac] #51670: Multisite test failures on GitHub Actions

[WordPress Trac]

#51670: Multisite test failures on GitHub Actions
---------------------------------------------+---------------------
 Reporter:  SergeyBiryukov                   |       Owner:  (none)
     Type:  defect (bug)                     |      Status:  new
 Priority:  normal                           |   Milestone:  5.6
Component:  Build/Test Tools                 |     Version:
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+---------------------
Changes (by desrosj):

 * keywords:  needs-testing has-patch has-unit-tests => has-patch has-unit-
     tests commit


Comment:

 Props to @ocean90 for working through this with me (and doing most of the
 work).

 [attachment:"51670.diff"] is the solution we arrived at.

 Instead of forcing the version control check to be `false` or only
 disabling `async_update_translation` only in the class causing the issue,
 [attachment:"51670.diff"] disables auto-update and async translation
 updates attempts for the entire test suite.

 There are no PHPUnit tests for this code, and they are more appropriate
 for E2E tests anyway. If a unit tests needs to test these two things, they
 can be re-enabled with another `add_filter` call inside the relevant test
 function.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51670#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform