[wp-trac] [WordPress Trac] #51665: wp_get_image_editor() ->save stopped creating the directory in 5.6-beta2-49360

[WordPress Trac]

#51665: wp_get_image_editor() ->save stopped creating the directory in
5.6-beta2-49360
-------------------------------------------------+-------------------------
 Reporter:  eemitch                              |       Owner:
                                                 |  mikeschroder
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.6
Component:  Media                                |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by mikeschroder):

 * keywords:   => has-patch needs-testing needs-unit-tests
 * owner:  (none) => mikeschroder
 * status:  new => assigned


Comment:

 It looks like it is because this behavior was missed when `make_image()`
 stopped being used:
 https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
 image-editor.php?rev=49230#L490

 Something like this looks to do the trick in initial testing:
 [attachment:"51665.diff"]

 Automated tests would be good, too, to prevent future regressions.

 cc: @p00ya for another opinion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51665#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform