[wp-trac] [WordPress Trac] #47656: Remove 'Error:' prefixes from error notices as they're redundant

[WordPress Trac]

#47656: Remove 'Error:' prefixes from error notices as they're redundant
-------------------------+-------------------------------------------------
 Reporter:  garrett-     |       Owner:  audrasjb
  eclipse                |
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  5.5
Component:  I18N         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, accessibility, administration,
  needs-testing          |  ui-copy
-------------------------+-------------------------------------------------
Changes (by sabernhardt):

 * keywords:   => has-patch needs-testing


Comment:

 Thanks for the patch, @quadthemes!

 I like most of your wording improvements, but I edited a few:
 1. I corrected the verb agreement for the "Passwords don't match" error.
 2. The already-registered username and email address errors now
 consistently have a period before "Please" and they still use the word
 "This". (If changing "This" to "That" is preferred, I have no strong
 opinion either way.)
 3. If we add the word "text" to the empty comment error, I think it would
 be better to use the word "your": `Please type your comment text.`

 The messages from `wp_get_theme()->errors()->get_error_message()`
 **might** benefit from keeping the 'Error:' prefix, yet the prefix is
 removed in my patch, too. (The code is found in
 [https://core.trac.wordpress.org/browser/tags/5.2.2/src/wp-
 admin/themes.php?marks=231#L229 wp-admin/themes.php].)

 So in 47656.1.diff, these new strings are revised beyond simply removing
 the Error prefix (changes in bold):
 1. **Passwords don’t match.** Please enter the same password in both
 password fields.
 2. **Please enter** a username or email address.
 3. Please type **your comment text**.
 4. Site URL **you’ve entered is** already taken.
 5. **There was a problem** creating site entry.
 6. This email is already **registered. Please** choose another one.
 7. **You can’t reply** to a comment on a draft post.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47656#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform