[wp-trac] [WordPress Trac] #50052: Plugins & Themes Auto-Updates 🤖

[WordPress Trac]

#50052: Plugins & Themes Auto-Updates 🤖
-------------------------------------------------+-------------------------
 Reporter:  whyisjake                            |       Owner:  whyisjake
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  Security                             |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing needs-design-feedback  |     Focuses:  ui,
  needs-docs has-patch needs-dev-note            |  administration
-------------------------------------------------+-------------------------

Comment (by desrosj):

 Great work here everyone! Great to see this get merged. I did some testing
 today, and have a bit of feedback.

 First, a bug that I found on the themes page.
 - Click on Theme Details for a theme.
 - Click "Enable auto-updates".
 - Auto-updates are correctly enabled.
 - Close that theme's overlay.
 - Click on Theme Details for the same theme and note that it says "Enable
 auto-updates" again.
 - Refresh the page and view that theme again to see auto-updates is
 correctly enabled.

 The emails also feel like they are lacking a bit of context. For example,
 the site is not linked to anywhere in the email. It's also not clear if
 any action is required when receiving the email, and there's no direction
 where they should navigate if they experience issues.

 I think the first two sentences in the Core update email could be
 repurposed a bit:

 > Howdy! Some plugins and/or themes on your site at https://site.com have
 been updated automatically to new versions.
 >
 > No further action is needed on your part. Here are some helpful links
 for managing plugins and themes on your site:
 > - Plugins screen: https://site.com/wp-admin/plugins.php
 > - Themes screen: https://site.com/wp-admin/themes.php

 It's possible that this could have been discussed previously and I missed
 it while I was out on leave.

 I also agree with @SergeyBiryukov and @pbiron above that
 `send_theme_auto_update_email` should be changed to
 `auto_theme_update_send_email` and I don't think that the `wp_` prefix is
 necessarily needed.

 The filters could also be moved into the `if( ! empty(
 $update_results['type'] ) )` checks. This is probably a micro-
 optimization, but this would ensure the filters only run when there are
 actually updates for that filter type.

 I'll continue testing and update with anything else I find!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50052#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform