[wp-trac] [WordPress Trac] #37011: Don’t link custom logo if it’s displayed on the front page

[WordPress Trac]

#37011: Don’t link custom logo if it’s displayed on the front page
-------------------------------------------------+-------------------------
 Reporter:  FlorianBrinkmann                     |       Owner:  joedolson
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.5
Component:  Themes                               |     Version:  4.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-dev-   |     Focuses:
  note                                           |  accessibility
-------------------------------------------------+-------------------------

Comment (by samful):

 Tested the Core themes (Twenty Nineteen, Twenty Seventeen & Twenty Twenty)
 with 37011.2.diff on standard WordPress and Multisite WordPress and no
 issues here.

 Setting the home page as a static page or leaving it as "Your latest
 Posts" seems to all work, the  is_front_page() function seems to be doing
 it's job well.

 On the Twenty Nineteen theme, the logo still has an on hover effect around
 it (a black circle) which may confuse some users, but I think this isn't a
 big issue as the cursor does not change, and so clearly isn't a hyperlink.

 I agree that the some of the 'a' element themes may need changing after
 this patch, however after testing the number 1 on that list, the
 "Mesmerize" theme seems to still work as expected.

 The since notes seems clear enough to me @sabernhardt , I've think you've
 done a good job here.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37011#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform