[wp-trac] [WordPress Trac] #50242: update jQuery version string in file to confirm not stock 1.12.4?

WordPress Trac noreply at wordpress.org
Mon May 25 10:10:40 UTC 2020


#50242: update jQuery version string in file to confirm not stock 1.12.4?
--------------------------------+------------------------------
 Reporter:  OptimizingMatters   |       Owner:  (none)
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  External Libraries  |     Version:
 Severity:  normal              |  Resolution:  invalid
 Keywords:                      |     Focuses:
--------------------------------+------------------------------
Changes (by OptimizingMatters):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Discussed this with Liran Tal at Snyk and they use
 https://github.com/johnmichel/Library-Detector-for-Chrome which does not
 look at version strings in URL or comments, but uses jQuery's built in
 [.jquery]https://api.jquery.com/jquery-2/ to [retrieve the version string
 and then removes all non-digits except periods and the plus-
 sign]https://github.com/johnmichel/Library-Detector-for-
 Chrome/blob/b4f9a007addc19608a3864943aa735e8be6a6444/library/libraries.js#L215.

 Changing
 {{{
 m=1.12.4
 }}}

 into e.g.

 {{{
 m=1.12.4++
 }}}

 in the minified jQuery code itself works, as the added plusses make the
 version not match 1.12.4, but I have no idea what the consequences could
 be as who knows what plugins have JS that checks the jQuery version before
 doing stuff? :-/

 So this ''might'' become a wontfix I guess, unless someone sees a
 solution?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50242#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list