[wp-trac] [WordPress Trac] #50199: Theme Editor: Remove unused $has_templates boolean

WordPress Trac noreply at wordpress.org
Fri May 22 23:19:03 UTC 2020


#50199: Theme Editor: Remove unused $has_templates boolean
----------------------------------------+-----------------------------
 Reporter:  SergeyBiryukov              |       Owner:  SergeyBiryukov
     Type:  defect (bug)                |      Status:  closed
 Priority:  normal                      |   Milestone:  5.5
Component:  Themes                      |     Version:
 Severity:  trivial                     |  Resolution:  fixed
 Keywords:  needs-patch good-first-bug  |     Focuses:  administration
----------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"47844" 47844]:
 {{{
 #!CommitTicketReference repository="" revision="47844"
 Theme Editor: Remove unused `$has_templates` boolean.

 The variable is a remnant from when the Theme Editor still had the
 "Templates" heading and is unused in the current logic.

 The condition it was a part of would always evaluate to true for a child
 theme, regardless of the `$has_templates` value.

 Props dboy1988.
 Fixes #50199.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50199#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list