[wp-trac] [WordPress Trac] #49236: Use 'comment' instead of '' for the comment_type db field for comments

[WordPress Trac]

#49236: Use 'comment' instead of '' for the comment_type db field for comments
-------------------------------------------------+-------------------------
 Reporter:  imath                                |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  5.5
Component:  Comments                             |     Version:  5.4
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch early needs-dev-note       |     Focuses:
  commit                                         |
-------------------------------------------------+-------------------------

Comment (by jeherve):

 I thought I would jump in to share my experience with this change, when
 maintaining themes.

 In r47597, Twenty Ten had to be updated to take the new type into account
 and ensure that new comments get displayed properly on sites using that
 theme. This seems like a small change, but in practice I found that
 several themes, even popular ones that are actively maintained, use the
 same `switch` method as in Twenty Ten and will be impacted by this change.

 A dev note (with a cross-post to make/themes) will definitely be useful
 for theme developers that monitor core changes.  However, I worry that
 some theme authors may not have enough time to implement those changes and
 get all sites updated before WordPress 5.5 rolls out. This is especially
 true for themes in the WordPress.org theme repository.

 With this in mind, should we attempt to post that dev note as early as
 possible so theme authors can start working on updates today?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49236#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform