[wp-trac] [WordPress Trac] #50199: Theme Editor: Remove unused $has_templates boolean

WordPress Trac noreply at wordpress.org
Thu May 21 10:05:02 UTC 2020


#50199: Theme Editor: Remove unused $has_templates boolean
----------------------------------------+-----------------------------
 Reporter:  SergeyBiryukov              |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  5.5
Component:  Themes                      |     Version:
 Severity:  trivial                     |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:  administration
----------------------------------------+-----------------------------

Comment (by dboy1988):

 Hi,

 I am not sure that is right.

 On line **77**: $has_templates = false is declared.

 On line **85**: if $allowed_files is not empty, $has_templates will be set
 to true.

 Then down on line **254**: if the theme is a child theme, it uses that
 boolean value to decide if the message, This child theme inherits
 templates from a parent theme (Parent theme name)

 To me it seems like it is still required?

 Please let me know if I am wrong.

 Thanks

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50199#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list