[wp-trac] [WordPress Trac] #50052: Plugins & Themes Auto-Updates 🤖

[WordPress Trac]

#50052: Plugins & Themes Auto-Updates 🤖
-------------------------------------------------+-------------------------
 Reporter:  whyisjake                            |       Owner:  whyisjake
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  Security                             |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing needs-design-feedback  |     Focuses:  ui,
  needs-docs has-patch needs-dev-note            |  administration
-------------------------------------------------+-------------------------

Comment (by pbiron):

 Replying to [comment:32 SergeyBiryukov]:
 > Great work, everyone! Reopening for some minor cleanup.
 >
 > Could these two filters use a consistent naming pattern?
 >
 > * `auto_plugin_update_send_email`
 > * `send_theme_auto_update_email`
 >
 > For reference, here are the other three new filters:
 >
 > * `auto_plugin_theme_update_email`
 > * `wp_plugins_auto_update_enabled`
 > * `wp_themes_auto_update_enabled`
 >
 > Do the latter two need the `wp_` prefix?

 `send_theme_auto_update_email` should be changed to
 `auto_theme_update_send_email`.

 For reference, the existing filter for whether to send core auto-update
 notifications is `auto_core_update_send_email`.  I changed the filter name
 for plugin auto-update notifications (from what is in the feature plugin)
 to have that form, but it looks like I just forgot to change the one for
 themes.

 As for the `wp_` prefix, they have that prefix in the feature plugin and
 since there are ALOT of existing filters in core with that prefix I didn't
 think to remove it.  I have no objection to removing it.  @audrasjb what
 do you think?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50052#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform