[wp-trac] [WordPress Trac] #48491: [Theme compatibility] WP/PHP compatibility tests for single site theme updates/activation

[WordPress Trac]

#48491: [Theme compatibility] WP/PHP compatibility tests for single site theme
updates/activation
-------------------------------------------------+-------------------------
 Reporter:  afragen                              |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.5
Component:  Site Health                          |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing dev-         |     Focuses:
  feedback early servehappy needs-copy-review    |  administration
  has-screenshots needs-dev-note                 |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 This is great work, I'm sorry the review took so long. There really are a
 lot of different layers and parts of the themes UI, so testing that
 everything works as expected is non-trivial.

 Some notes on the patch:
 * No need to use `ReflectionObject` in `wp-admin/customize.php`, the
 `WP_Customize_Manager::theme()` method can be used to retrieve the theme
 object instead.
 * It seems like the update parts need some more work. Unless I've missed
 something in my testing, at least in a few places the messages state that
 the theme update is incompatible, but the compatibility checks are
 actually performed for the currently installed version, not for the
 update.
 * The activation parts look good, commit incoming.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48491#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform