[wp-trac] [WordPress Trac] #50075: Trigger _doing_it_wrong for dangerous REST API endpoint option

WordPress Trac noreply at wordpress.org
Sat May 16 19:51:03 UTC 2020


#50075: Trigger _doing_it_wrong for dangerous REST API endpoint option
--------------------------------------+---------------------
 Reporter:  rmccue                    |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  5.5
Component:  REST API                  |     Version:  4.4
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by TimothyBlynJacobs):

 > IMO no, as that's a potential footgun too; if you accidentally cast to
 true or something crazy. I think it also complicates the API surface for
 no real gain, given `__return_true` already exists.

 Works for me.

 > Note that I'm only suggesting the misspelling here, not the lack of
 permission_callback; while that would be OK, it's a bit of an API
 breakage, and would cause a lot of warnings.

 Ah, I misunderstood. Yeah I'm conflicted about it, I kinda hoped that the
 issue last year would be a "one and done" type of deal, but it has cropped
 up again. I'm not sure if it is worth the noise.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50075#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list