[wp-trac] [WordPress Trac] #50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug

[WordPress Trac]

#50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug
--------------------------+------------------------------
 Reporter:  arena         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Feeds         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by arena):

 I am really sorry. i mean it !

 i took my tests from the beginning ... and developped a little plugin to
 test different cases (one test at a time).

 and here is the result of a test using the filter ... filter code is a bit
 complicated !

 {{{

 **************** TEST 04 ***********************
  * 04 *  ** using fetch_feed with filter (lifetime = 410363262) and two
 feeds as array :
 ["http:\/\/wordpress.org\/development\/feed\/","https:\/\/www.theverge.com\/rss\/index.xml"]
  * 04 *  rows in wp_options where option_name like "_transient%feed%" : 0
  * 04 * +++++ filter(1)
  * 04 * +++++ filter(1) beg >> lifetime >> 43200
  * 04 * +++++ filter(1) beg >> 2nd arg  >>
 ["http:\/\/wordpress.org\/development\/feed\/","https:\/\/www.theverge.com\/rss\/index.xml"]
  * 04 * +++++ filter(1) ++ filtered : should be 1st call (2nd func arg
 string or array)
  * 04 * +++++ filter(1) end >> lifetime >> 410363262
  * 04 * +++++ filter(2)
  * 04 * +++++ filter(2) beg >> lifetime >> 43200
  * 04 * +++++ filter(2) beg >> 2nd arg  >>
 0ff4b43bd116a9d8720d689c80e7dfd4
  * 04 * +++++ filter(2) ++ filtered : should be 2nd call and 2nd arg is
 one of array of many
  * 04 * +++++ filter(2) end >> lifetime >> 410363262
  * 04 * +++++ filter(3)
  * 04 * +++++ filter(3) beg >> lifetime >> 43200
  * 04 * +++++ filter(3) beg >> 2nd arg  >>
 196f73e8cf4330017ab92ef17541ebea
  * 04 * +++++ filter(3) ++ filtered : should be 2nd call and 2nd arg is
 one of array of many
  * 04 * +++++ filter(3) end >> lifetime >> 410363262
  * 04 *  rows in wp_options where option_name like "_transient%feed%" : 8
  * 04 *
 79541   _transient_timeout_feed_0ff4b43bd116a9d8720d689c80e7dfd4
 2000000001
 79542   _transient_feed_0ff4b43bd116a9d8720d689c80e7dfd4
 a:4:{s:5:"child";a:1:
 79543   _transient_timeout_feed_mod_0ff4b43bd116a9d8720d689c80e7dfd4
 2000000001
 79544   _transient_feed_mod_0ff4b43bd116a9d8720d689c80e7dfd4    1589636739
 79545   _transient_timeout_feed_196f73e8cf4330017ab92ef17541ebea
 2000000002
 79546   _transient_feed_196f73e8cf4330017ab92ef17541ebea
 a:4:{s:5:"child";a:1:
 79547   _transient_timeout_feed_mod_196f73e8cf4330017ab92ef17541ebea
 2000000002
 79548   _transient_feed_mod_196f73e8cf4330017ab92ef17541ebea    1589636740
 }}}

 i attach the plugin to the ticket (SimplePieCacheTester.php). It removes
 all feed cache from options table. Once activated visit admin page wp-
 admin/tools.php

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50159#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform