[wp-trac] [WordPress Trac] #50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug

WordPress Trac noreply at wordpress.org
Thu May 14 15:42:49 UTC 2020


#50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug
--------------------------+------------------------------
 Reporter:  arena         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Feeds         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by arena):

 ok let's get back to the patch and i explain it step by step

 **WP_Feed_Cache_Transient** implements SimplePie_Cache_Base
 implementing the interface is a requirement of simplepie

 * md5 or not md5 ... i do not know how simplepie can apply a second md5 on
 a part of a string ... still a mistery for me. Anyway, if you want to
 remove this md5, just do it !

 * transient lifetime is passed as a parameter of simplepie cache location
 (to avoid to have the same filter called twice, meaning not executing
 twice the same add_filter code if any

 **WP_Feed_Cache**

 see simplepie doc

 * ''$feed->registry->register'' the new way to set class in SimplePie

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50159#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list