[wp-trac] [WordPress Trac] #50165: Synchronize get_theme_feature_list() with the Theme Directory

[WordPress Trac]

#50165: Synchronize get_theme_feature_list() with the Theme Directory
----------------------------+-----------------------------
 Reporter:  SergeyBiryukov  |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  5.5
Component:  Themes          |     Version:  4.9
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  administration
----------------------------+-----------------------------
Description changed by SergeyBiryukov:

Old description:

> [41648] removed a bunch of theme features from
> `get_theme_feature_list()`:
>
> * BuddyPress
> * Custom Menu
> * Flexible Header
> * Front Page Posting
> * Microformats
> * RTL Language Support
> * Threaded Comments
> * Translation Ready
>
> This resulted in the core list being out of sync with the Theme
> Directory, and in these strings not being translated when returned from
> the Theme Directory API.
>
> [42003] then disabled the API call on Add Themes screen "due to
> inconsistencies and to ensure tags are translated".
>
> It's not quite clear whether the removing was intentional, as I could not
> find any justification in the linked tickets. These features are still
> displayed in Theme Directory filters and are returned in the API
> response.
>
> If it was indeed intentional, let's update the Theme Directory to match.
>
> If not, let's update the core list to match the Theme Directory.

New description:

 [41648] removed a bunch of theme features from `get_theme_feature_list()`:

 * BuddyPress
 * Custom Menu
 * Flexible Header
 * Front Page Posting
 * Microformats
 * RTL Language Support
 * Threaded Comments
 * Translation Ready

 This resulted in the core list being out of sync with the Theme Directory,
 and in these strings not being translated when returned from the Theme
 Directory API.

 [42003] then disabled the API call on Add Themes screen "due to
 inconsistencies and to ensure tags are translated".

 With that change, every instance of `get_theme_feature_list()` as of
 WordPress 4.9 no longer calls the API and just returns the hardcoded list.
 One exception is the instance in `install_themes_dashboard()`, however
 that function is not used anywhere.

 It's not quite clear whether the removing was intentional, as I could not
 find any justification in the linked tickets. These features are still
 displayed in Theme Directory filters and are returned in the API response.

 If it was indeed intentional, let's update the Theme Directory to match.

 If not, let's update the core list to match the Theme Directory.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50165#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform