[wp-trac] [WordPress Trac] #9757: Allow Plugin/Theme updates from a uploaded .zip file.
WordPress Trac
noreply at wordpress.org
Thu May 14 00:53:54 UTC 2020
#9757: Allow Plugin/Theme updates from a uploaded .zip file.
------------------------------------------+-----------------------------
Reporter: hakre | Owner: psykro
Type: feature request | Status: accepted
Priority: high | Milestone: Future Release
Component: Upgrade/Install | Version: 2.8
Severity: normal | Resolution:
Keywords: dev-feedback has-patch early | Focuses:
------------------------------------------+-----------------------------
Comment (by mariovalney):
OK. That was not trivial.
I would really like a core developer feedback, because I'm not sure
implementing this in the "Install Skin" is the best approach. But I was
not able to figure another way (at least, without change much more code).
1 - I really tried to keep this for "upload" only.
2 - Would we trigger any action like in upgrade?
I guess don't. Because we are not keeping this for upgrade only. In this
case, let's deactivate/activate the plugin?
I added a action on overwriting completed to allow developers do whatever
they want on "manual update".
3 - I added some CSS. Is that the best place?
4 - As said, we are not checking versions. But we are showing comparison
table only if we found plugin data in existing directory and after
validating the uploaded package is a plugin.
5 - Maybe implement a new action on **update.php** to check a new nonce
for this package ID?
This will not allow user overwrite a package by adding parameter on URL.
**How the table looks like:**
[[Image(https://i.imgur.com/iT2JNGe.png)]]
''Note: themes are very like plugins in this case, so let's do the theme
part after eveything is considered about plugins.''
--
Ticket URL: <https://core.trac.wordpress.org/ticket/9757#comment:106>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list