[wp-trac] [WordPress Trac] #50159: Simplepie 1.5.5 - code review and modifications
WordPress Trac
noreply at wordpress.org
Wed May 13 22:08:24 UTC 2020
#50159: Simplepie 1.5.5 - code review and modifications
--------------------------------------+------------------------------
Reporter: arena | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Feeds | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------------
Comment (by arena):
Yes, i have noticed that too. This is a replication of the samples
provided by SimplePie.
This transient has a 12 hours lifetime by default and if deprecated will
be erased by appropriate wp-cron job 'delete_expired_transients'.
I also changed some class names and added 2 new files
Replying to [comment:12 afragen]:
> You have also changed the transient names.
>
>
> {{{
> 54 $this->name = 'feed_' . $filename;
> 55 $this->mod_name = 'feed_mod_' . $filename;
> }}}
>
> to
>
>
> {{{
>
> 54 $this->name = 'feed_' . md5(
"$filename:$extension" );
> 55 $this->mod_name = 'feed_mod_' . md5(
"$filename:$extension" );
>
> }}}
>
> This particular item will cause an issue for me.
> https://github.com/afragen/wordpress-beta-
tester/blob/develop/src/WPBT/WPBT_Beta_RC.php#L520-L522
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50159#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list