[wp-trac] [WordPress Trac] #50159: Simplepie 1.5.5 - code review and modifications

WordPress Trac noreply at wordpress.org
Wed May 13 21:51:22 UTC 2020


#50159: Simplepie 1.5.5 - code review and modifications
--------------------------------------+------------------------------
 Reporter:  arena                     |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Feeds                     |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------

Comment (by afragen):

 Replying to [comment:10 arena]:
 > Yes, filename is used because this is the name of the variable used in
 SimplePie native class but this is the same !
 >
 > Replying to [comment:8 afragen]:
 > > In one of the removed filters the 2nd parameter is $filename. In your
 patch it is $url.

 Look at line 776.

 {{{
 776            $lifetime = apply_filters(
 'wp_feed_cache_transient_lifetime', 12 * HOUR_IN_SECONDS, $url );
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50159#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list