[wp-trac] [WordPress Trac] #38665: Add user language preference to 'Add new user' form

WordPress Trac noreply at wordpress.org
Sat May 2 15:46:15 UTC 2020


#38665: Add user language preference to 'Add new user' form
-------------------------------------------------+-------------------------
 Reporter:  barryceelen                          |       Owner:
                                                 |  johnbillion
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  Users                                |     Version:  4.7
 Severity:  normal                               |  Resolution:
 Keywords:  needs-dev-note needs-testing has-    |     Focuses:
  patch                                          |  administration
-------------------------------------------------+-------------------------

Comment (by afercia):

 Looking at [attachment:"38665.3.diff"], I'd like to suggest to add an
 inline comment where `$user->locale` is set to empty string. That may help
 avoid the same mistake in the future, as it's not immediately clear why
 it's needed. See

 > Also removes setting $user->locale = ''. Unsure why that was there in
 the first place?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38665#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list