[wp-trac] [WordPress Trac] #48948: Fix the Site Health template to produce valid HTML

WordPress Trac noreply at wordpress.org
Sun Mar 29 03:44:05 UTC 2020


#48948: Fix the Site Health template to produce valid HTML
---------------------------------------+-----------------------------
 Reporter:  afercia                    |       Owner:  SergeyBiryukov
     Type:  defect (bug)               |      Status:  reviewing
 Priority:  normal                     |   Milestone:  5.5
Component:  Site Health                |     Version:  5.2
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 It looks like `<p class="button-container">` here was copied from
 [source:tags/5.3.2/src/wp-
 admin/includes/dashboard.php?marks=1712,1722#L1693
 wp_dashboard_php_nag()].

 Since this class is unused in core and Site Health actions only contain
 links, not buttons, I think there's currently no need to replace the `<p>`
 tag with `<div>`, it can just be removed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48948#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list