[wp-trac] [WordPress Trac] #49268: Broken themes should always be listed

WordPress Trac noreply at wordpress.org
Fri Mar 13 05:43:46 UTC 2020


#49268: Broken themes should always be listed
--------------------------------------+------------------------------
 Reporter:  johnbillion               |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Themes                    |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  administration
--------------------------------------+------------------------------

Comment (by sorenbronsted):

 Thanks @rebasaurus and it works, but for me there is a catch-22 to this
 bug report.

 I presume that I can use {{{DISALLOW_FILE_MODS}}} constant to prevent
 users makes changes to a site.

 If the constant {{{DISALLOW_FILE_MODS}}} is true then the first patch by
 @rebasaurus actually solves this, by showing to the user that there are
 themes which are broken, but the user can't do anything about it, because
 the user is not allowed to modify files. For me this is by design.

 By allowing to modify files/themes even if {{{DISALLOW_FILE_MODS}}} is
 true defeats the purpose of this constant.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49268#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list