[wp-trac] [WordPress Trac] #48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
WordPress Trac
noreply at wordpress.org
Fri Mar 13 04:35:46 UTC 2020
#48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
-------------------------------------+-------------------------
Reporter: gziolo | Owner: gziolo
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.5
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: needs-patch 2nd-opinion | Focuses: javascript
-------------------------------------+-------------------------
Comment (by azaozz):
To ignore `/src/wp-includes/assets` again it will have to be SVN deleted,
and added to the ignored props on the parent dir, `/src/wp-includes`.
Then, when building, it will be created again but will not be committed.
> We need to ensure that PHPUnit tests pass without JS build files.
As far as I see the only way to do that is to add a `file_exists()` in
script-loader.php. With 48154-update-file-check.diff it could be a "silent
check" as it will never be reached when running WP, only when testing. On
the other hand, can still throw "doing it wrong" user-notice perhaps?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48154#comment:83>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list