[wp-trac] [WordPress Trac] #47053: Accessibility: Need to set proper 'tabindex' in 'Skip To Toolbar' HTML

[WordPress Trac]

#47053: Accessibility: Need to set proper 'tabindex' in 'Skip To Toolbar' HTML
-------------------------------------------------+-------------------------
 Reporter:  jankimoradiya                        |       Owner:  joedolson
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.4
Component:  Toolbar                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch early      |     Focuses:  ui,
  commit has-dev-note                            |  accessibility
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Having second thoughts about the approach in [47221].

 The usage of DocBlock syntax is not quite correct there, as it's neither a
 function nor a hook definition, just an `if` condition. WordPress core
 does not generally have DocBlocks for random pieces of code like this.

 More importantly, this logic is specific to `wp_admin_bar_render()` and
 should be handled in that function, it does not belong in `wp_footer()`.

 [attachment:"47053.6.diff"] addresses this. No functional difference here,
 just more appropriate logic.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47053#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform