[wp-trac] [WordPress Trac] #48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build

[WordPress Trac]

#48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
-------------------------------------+-------------------------
 Reporter:  gziolo                   |       Owner:  gziolo
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.5
Component:  Build/Test Tools         |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch 2nd-opinion  |     Focuses:  javascript
-------------------------------------+-------------------------

Comment (by peterwilsoncc):

 > Think this happened only once after script-loader-packages.php was
 updated and committed manually. Have you seen this happen again? Can it be
 reproduced consistently?

 Mainly seeing it switching branch to branch as I review code on repos I
 can't commit too.

 > This will bring back the previous bug (non-existing file) when building
 to /build and running tests on /src, and similar.

 In [attachment:"48154-update-file-check.diff"] I've modified the file
 looked for to determine if a site has been built when running from the
 WordPress-develop repo.

 Without `wp-includes/assets/script-loader-packages.php`, the JavaScript
 can not be run (no dependency array) and as it's generated during the
 build processes the remaining instructions in `/src/index.php` are enough.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48154#comment:79>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform