[wp-trac] [WordPress Trac] #49539: Twenty Twenty: fix theme issues

[WordPress Trac]

#49539: Twenty Twenty: fix theme issues
---------------------------+-------------------------------
 Reporter:  fahimmurshed   |       Owner:  williampatton
     Type:  defect (bug)   |      Status:  assigned
 Priority:  normal         |   Milestone:  Future Release
Component:  Bundled Theme  |     Version:  5.3
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:  coding-standards
---------------------------+-------------------------------
Changes (by williampatton):

 * owner:  (none) => williampatton
 * status:  new => assigned


Comment:

 Hey @fahimmurshed, thanks for hilighti g these in a ticket.

 All of these items (except maybe the `$content_width` one) are actually
 false positives.

 The content width could likely be set via filter instead although I can't
 remember the exact filter for it off the top of my head.

 `wp_body_open()` is a back compat shim for core and old versions of WP. It
 needs to be unprefixed.

 The hook names in the walker remain as-is to stay compatible with the core
 class it extends from.

 The global vars inside templates are actually scoped when used. PHPCS just
 cannot see that they get invoked inside functions of the core template
 loader because it analyses statically (IE without running them or WP at
 all).

 I'll pick up this ticket for now till I double confirm these items are not
 problems. Likely only change needed will be the one for content_width :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49539#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform