[wp-trac] [WordPress Trac] #49549: Bundled Themes: Update calendar widget styles for 5.4 markup

WordPress Trac noreply at wordpress.org
Mon Mar 9 18:12:33 UTC 2020


#49549: Bundled Themes: Update calendar widget styles for 5.4 markup
-------------------------------------+--------------------------
 Reporter:  ianbelanger              |       Owner:  ianbelanger
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.4
Component:  Bundled Theme            |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  css
-------------------------------------+--------------------------
Changes (by sabernhardt):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @ianbelanger I'm reopening this ticket because I had failed to test how
 the table/table-cell layout works with only one month link. In that case,
 which again is most noticeable with Twenty Thirteen, the link takes up
 about 80% of the table width (about 6 columns).

 It seems the spans should have a specific (percentage) width for the
 themes where that element has centered text. 49549.2.patch sets the
 previous and next spans to 40% in those six themes. Those container
 elements had been three-sevenths (42.86%) as table footer cells, and I
 rounded down for a better chance of even pixel values.

 Simply setting previous and next links' width at 40%:
 1. Twenty Eleven
 2. Twenty Thirteen
 3. Twenty Nineteen

 Setting previous and next width at 40% instead of the 15% `.pad` width I
 used earlier:
 4. Twenty Fifteen
 5. Twenty Sixteen
 6. Twenty Seventeen

 I've tested 49549.2.patch:
 * with each bundled theme,
 * in 4 PC browsers (Chrome, Firefox, IE11, and Edge),
 * in English and Hebrew (LTR and RTL languages), and
 * with each link set (previous month only, next month only, and both).

 Side note: Twenty Twenty can lose some table border lines in Internet
 Explorer and Edge, but it already did that in 5.3 (so I'm not addressing
 that here).

 If the width issue is minor enough, this edit could be punted to 5.5 (or
 possibly even ignored).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49549#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list