[wp-trac] [WordPress Trac] #39735: Right check for wp_update_comment (WP_REST_Comments_Controller::update_item)

[WordPress Trac]

#39735: Right check for wp_update_comment
(WP_REST_Comments_Controller::update_item)
-------------------------------+-----------------------
 Reporter:  enrico.sorcinelli  |       Owner:  (none)
     Type:  defect (bug)       |      Status:  closed
 Priority:  normal             |   Milestone:
Component:  REST API           |     Version:  4.7
 Severity:  normal             |  Resolution:  invalid
 Keywords:                     |     Focuses:  rest-api
-------------------------------+-----------------------

Comment (by SergeyBiryukov):

 In [changeset:"48235" 48235]:
 {{{
 #!CommitTicketReference repository="" revision="48235"
 Comments: Make `wp_update_comment()` return `false` instead of 0 for an
 invalid comment or post ID.

 This addresses an inconsistency where 0 could mean one of the three
 scenarios:

 * Invalid comment ID.
 * Invalid comment post ID.
 * No DB rows updated. This is not an error and should not be treated as
 one.

 With this change, `wp_update_comment()` always returns either `false` or a
 `WP_Error` object on failure, depending on the value of the `$wp_error`
 parameter.

 Follow-up to [48154], [48215], [48216], [48218], [48230].

 Props dd32, jnylen0, enrico.sorcinelli.
 Fixes #39732. See #38700, #39735.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39735#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform