[wp-trac] [WordPress Trac] #39732: Allowing wp_update_comment() to return WP_Error
WordPress Trac
noreply at wordpress.org
Tue Jun 30 14:11:17 UTC 2020
#39732: Allowing wp_update_comment() to return WP_Error
-------------------------------------------------+-------------------------
Reporter: enrico.sorcinelli | Owner:
| enrico.sorcinelli
Type: enhancement | Status: closed
Priority: normal | Milestone: 5.5
Component: Comments | Version: 4.8
Severity: normal | Resolution: fixed
Keywords: has-patch has-unit-tests needs-dev- | Focuses:
note commit |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):
* status: reopened => closed
* resolution: => fixed
Comment:
In [changeset:"48235" 48235]:
{{{
#!CommitTicketReference repository="" revision="48235"
Comments: Make `wp_update_comment()` return `false` instead of 0 for an
invalid comment or post ID.
This addresses an inconsistency where 0 could mean one of the three
scenarios:
* Invalid comment ID.
* Invalid comment post ID.
* No DB rows updated. This is not an error and should not be treated as
one.
With this change, `wp_update_comment()` always returns either `false` or a
`WP_Error` object on failure, depending on the value of the `$wp_error`
parameter.
Follow-up to [48154], [48215], [48216], [48218], [48230].
Props dd32, jnylen0, enrico.sorcinelli.
Fixes #39732. See #38700, #39735.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39732#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list