[wp-trac] [WordPress Trac] #50346: Make delete plugin message less scary

[WordPress Trac]

#50346: Make delete plugin message less scary
-------------------------------------+-----------------------------
 Reporter:  joostdevalk              |       Owner:  SergeyBiryukov
     Type:  enhancement              |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.5
Component:  Plugins                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------
Changes (by samful):

 * keywords:   => has-patch needs-testing


Comment:

 Adding a patch which sets a class on the delete <a> delete element, based
 on the wordpress {{{is_uninstallable_plugin()}}} function. All the PHP I
 could see seems to use this to identify if the plug-in has data or not,
 however the JavaScript used no such logic at all.

 By adding a "has-plugin-data" or "no-plugin-data" class to the <a>
 element, the JavaScript can display a different message. Hope this helps,
 Please see screenshots and test :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50346#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform