[wp-trac] [WordPress Trac] #50038: Check for `file_uploads` in Site Health
WordPress Trac
noreply at wordpress.org
Fri Jun 26 15:46:48 UTC 2020
#50038: Check for `file_uploads` in Site Health
--------------------------+---------------------
Reporter: dd32 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.5
Component: Site Health | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+---------------------
Comment (by ayeshrajans):
I guess GitHub code review comments don't sync here. Repeating my comment
on the PR
`$effective = min( $post_max_size, $upload_max_size );`
I'm not quite sure that this will work as intended. For example, min('4M',
'500K') returns 4M, and not 500K as expected. I think these values should
go through parse_ini_size() method before comparison.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50038#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list