[wp-trac] [WordPress Trac] #48713: Twenty Twenty: Social Icons Filter

[WordPress Trac]

#48713: Twenty Twenty: Social Icons Filter
--------------------------------------+---------------------
 Reporter:  JarretC                   |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  5.5
Component:  Bundled Theme             |     Version:  5.3
 Severity:  normal                    |  Resolution:
 Keywords:  needs-dev-note has-patch  |     Focuses:
--------------------------------------+---------------------
Changes (by desrosj):

 * keywords:  needs-patch needs-dev-note => needs-dev-note has-patch


Comment:

 [attachment:"48713.diff"] copies over the filters in the original PR on
 GitHub linked above.

 I removed the second and third parameters for the
 `twentytwenty_svg_icons_social` and `twentytwenty_svg_icons_{$group}`
 filters, though. They are called in two functions, but have different
 parameters available. `get_social_link_svg()` has no color available, and
 `get_svg()` has no `$uri`. This would have resulted in inconsistent data
 being passed.

 I also added a filter for the icon to domain mapping, and the color being
 used.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48713#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform