[wp-trac] [WordPress Trac] #49518: Consider adding domain-specific i18N filter hooks

WordPress Trac noreply at wordpress.org
Tue Jun 23 10:00:51 UTC 2020


#49518: Consider adding domain-specific i18N filter hooks
-------------------------------------------------+-------------------------
 Reporter:  geminilabs                           |       Owner:  whyisjake
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  5.5
Component:  I18N                                 |     Version:  5.3.2
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch needs-testing needs-dev-   |     Focuses:  coding-
  note 2nd-opinion                               |  standards
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"48136" 48136]:
 {{{
 #!CommitTicketReference repository="" revision="48136"
 I18N: Use underscores instead of dashes and interpolation instead of
 concatenation in domain-specific gettext hooks, per the coding standards:

 * `gettext_{$domain}`
 * `gettext_with_context_{$domain}`
 * `ngettext_{$domain}`
 * `ngettext_with_context_{$domain}`

 Additionally:
 * Pass `$domain` parameter to the new hooks, for consistency with their
 pre-existing counterparts.
 * Update documentation to explain the dynamic portion of the filter, for
 consistency with other dynamic hooks in core.

 Follow-up to [48131].

 Props swissspidy, knutsp, TimothyBlynJacobs, SergeyBiryukov.
 Fixes #49518.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49518#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list