[wp-trac] [WordPress Trac] #49518: Consider adding domain-specific i18N filter hooks
WordPress Trac
noreply at wordpress.org
Tue Jun 23 09:16:48 UTC 2020
#49518: Consider adding domain-specific i18N filter hooks
-------------------------------------------------+-------------------------
Reporter: geminilabs | Owner: whyisjake
Type: enhancement | Status: reopened
Priority: normal | Milestone: 5.5
Component: I18N | Version: 5.3.2
Severity: normal | Resolution:
Keywords: has-patch needs-testing needs-dev- | Focuses: coding-
note 2nd-opinion | standards
-------------------------------------------------+-------------------------
Comment (by swissspidy):
Scrolled through Slack to find
[https://wordpress.slack.com/archives/C02RQBWTW/p1592887603101500 the same
question].
One answer was:
> The domain `with_context` would collide with another filter without the
dash.
However, I'd say that's extremely unlikely. Even more generally speaking,
the norm is that the text domains matches the plugin slug, which uses
dashes anyway, not underscores.
----
More importantly though, the filter names to not adhere to coding
standards:
https://make.wordpress.org/core/handbook/best-practices/coding-
standards/php/#interpolation-for-naming-dynamic-hooks
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49518#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list