[wp-trac] [WordPress Trac] #50448: Add tolerance to plugin and theme auto-update failure emails

[WordPress Trac]

#50448: Add tolerance to plugin and theme auto-update failure emails
----------------------------+-------------------------
 Reporter:  desrosj         |      Owner:  (none)
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  5.5
Component:  Administration  |    Version:  trunk
 Severity:  normal          |   Keywords:  needs-patch
  Focuses:                  |
----------------------------+-------------------------
 From @johnbillion over on ticket:50268#comment:12:

 > This may be a separate issue, but under what conditions might a plugin
 automatic update fail and therefore trigger the failure email message? If
 it does fail and the problem is persistent, when does it next attempt to
 update? If I don't check my emails for let's say three days, how many
 failure emails might I have in my inbox?
 >
 > I ask in case we need to consider some failure tolerance here to avoid
 too many failure emails being sent out.

 Reading through the code that implements these auto-updates, it seems that
 these are the scenarios where a plugin or theme auto-update could
 potentially fail.

 1. The upgrader cannot connect to the file system.
 1. Package could not be unzipped.
 1. Old version of plugin could not be deleted.
 1. New version cannot be copied into the plugin's folder.
 1. An error occurs downloading the update package.
 1. Signature verification fails (eventually, not currently enforced).
 1. No plugin is found in the update package.
 1. The plugin is already at the latest version.

 Items 1-4 are likely to re-occur until admin action is taken, 5-7
 potentially could re-occur, but most likely indicate a problem upstream,
 and 8 will most likely not re-occur.

 Since auto-updates will be attempted every 12 hours by default, some
 tolerance should probably be added so that emails are only sent every few
 days when issues occur.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50448>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform