[wp-trac] [WordPress Trac] #50436: Unnecessary DISABLE_WP_CRON check in plugin and theme auto updates

[WordPress Trac]

#50436: Unnecessary DISABLE_WP_CRON check in plugin and theme auto updates
--------------------------------------+-----------------------
 Reporter:  johnbillion               |       Owner:  audrasjb
     Type:  defect (bug)              |      Status:  accepted
 Priority:  normal                    |   Milestone:  5.5
Component:  Security                  |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+-----------------------

Comment (by pbiron):

 On 2nd thought, I now agress with @johnbillion.  The check for
 `DISABLE_WP_CRON` being true is unnecessary.

 [https://core.trac.wordpress.org/attachment/ticket/50436/50436.diff
 50436.diff] refactors `wp_get_auto_update_message()` so that:

 1. there is no check for `DISABLE_WP_CRON`
 2. all returned strings now begin with `Automatic update...` (`Automatic
 update not scheduled.`, `Automatic update overdue by...` and `Automatic
 update scheduled in...`)
 3. there is a single return

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50436#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform