[wp-trac] [WordPress Trac] #50436: Unnecessary DISABLE_WP_CRON check in plugin and theme auto updates

[WordPress Trac]

#50436: Unnecessary DISABLE_WP_CRON check in plugin and theme auto updates
--------------------------------------+-----------------------
 Reporter:  johnbillion               |       Owner:  audrasjb
     Type:  defect (bug)              |      Status:  accepted
 Priority:  normal                    |   Milestone:  5.5
Component:  Security                  |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+-----------------------

Comment (by pbiron):

 As John says, that constant doesn't prevent a direct request of `/wp-
 cron.php` from triggering WP-Cron jobs (e.g., from a UNIX cron job; nor
 them being manually triggered by something like
 [https://wordpress.org/plugins/wp-crontrol/ WP Crontrol]).

 But I thought the reason for that check was to provide "context" for why
 the job may be overdue, but since it does an early when the constant is
 true the message could be misleading.

 Let me work up a patch that moves the check within the block that executes
 only if the job is overdue...

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50436#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform