[wp-trac] [WordPress Trac] #50436: Unnecessary DISABLE_WP_CRON check in plugin and theme auto updates

WordPress Trac noreply at wordpress.org
Sat Jun 20 08:25:57 UTC 2020


#50436: Unnecessary DISABLE_WP_CRON check in plugin and theme auto updates
--------------------------+----------------------------------------
 Reporter:  johnbillion   |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  5.5
Component:  Security      |    Version:  trunk
 Severity:  normal        |   Keywords:  needs-patch good-first-bug
  Focuses:                |
--------------------------+----------------------------------------
 The `wp_get_auto_update_message()` function added in [47835] checks the
 value of the `DISABLE_WP_CRON` constant and returns an error if it's set
 to `true`.

 This check is unnecessary. The `DISABLE_WP_CRON` constant disables the
 cron spawner, not cron altogether, and is used when an external cron
 spawner is in use (eg. a system-level cron runner). The use of this
 constant doesn't indicate a problem that needs to be shown here.

 The check for this constant can be removed altogether.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50436>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list