[wp-trac] [WordPress Trac] #48245: Add extra details to the error message for a plugin's minimum supported PHP version

[WordPress Trac]

#48245: Add extra details to the error message for a plugin's minimum supported PHP
version
-------------------------+-----------------------------
 Reporter:  johnbillion  |       Owner:  johnbillion
     Type:  enhancement  |      Status:  reviewing
 Priority:  normal       |   Milestone:  Future Release
Component:  Site Health  |     Version:  5.3
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+-----------------------------

Comment (by johnbillion):

 Thanks for the patch @stuffradio.

 I've taken a look and I've got some feedback for you. If you'd like to
 submit an updated patch you can upload it with the same file name.

 1. In order to aid translators when there are multiple placeholders within
 a string, these need to use the numbered placeholder syntax, eg `%1$s,
 %2$s`, and the translator comment above it should be numbered accordingly.
 Example: https://core.trac.wordpress.org/browser/trunk/src/wp-
 activate.php?rev=47550&marks=147-148#L139
 2. The string that's used when neither the required WordPress nor PHP
 versions are met needs some more clarity to explain that the two version
 numbers refer to WordPress and PHP respectively.
 3. I still think that including the ''current'' WordPress and/or PHP
 version number in the messages will help users. They might be more
 inclined to arrange an update than they would be if they had no idea which
 version they're currently on.
 4. The support article at https://wordpress.org/support/update-php/
 includes useful information about updating PHP. We should link to this
 article at the end of this message about updating PHP. There's a useful
 article on updating WordPress too: https://wordpress.org/support/article
 /updating-wordpress/.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48245#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform