[wp-trac] [WordPress Trac] #47656: Remove 'Error:' prefixes from error notices as they're redundant

[WordPress Trac]

#47656: Remove 'Error:' prefixes from error notices as they're redundant
-------------------------+-------------------------------------------------
 Reporter:  garrett-     |       Owner:  audrasjb
  eclipse                |
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  5.5
Component:  I18N         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, accessibility, administration,
                         |  ui-copy
-------------------------+-------------------------------------------------
Changes (by afercia):

 * keywords:  has-patch commit => has-patch


Comment:

 > If it happened in Slack, well… that’s not linked here either

 I can count 5 links to mentions of this ticket in Slack before your last
 comment.

 Regardless, as promised this ticket was discussed again during today's
 accessibility meeting. The prevalent opinion is to revert the commit.

 Also, the team agreed that ''all'' the "Error" and "Warning" notices need
 respectively a "Error:" and "Warning:" prefix. In fact, the prevalent
 opinion about these two types of notices is that it's either a "remove
 prefixes everywhere" or "add prefixes everywhere".

 The situation in core before this commit was greatly inconsistent and it
 is still inconsistent. Various Errors don't have a prefix, only a few
 Warnings have a prefix.

 Worth also reminding most of the admin notices are just hardcoded HTML.
 It's understandable that the lack of standard, reusable, methods to get /
 print out admin notices in a so large project contributes to inconsistency
 over time.

 Regarding the "Info" and "Success" notices there's no consensus yet.

 Some in the team feel the arguments for Errors and Warnings should apply
 also to Info and Success, i.e.: add "Info:" and "Success:" prefixes
 everywhere. Others feel it wouldn't be necessary.

 All the other considerations for better accessibility from comment:34
 still apply. They should go in a separate ticket.

 Thanks also to @sabernhardt who just beat me to reopen this ticket :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47656#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform