[wp-trac] [WordPress Trac] #49576: Menu Editor UI issues on med-large screens

WordPress Trac noreply at wordpress.org
Thu Jun 18 23:40:29 UTC 2020


#49576: Menu Editor UI issues on med-large screens
-------------------------------------+-------------------------------------
 Reporter:  garrett-eclipse          |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.5
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, css,
  patch needs-testing                |  administration
-------------------------------------+-------------------------------------
Changes (by garrett-eclipse):

 * keywords:  has-screenshots has-patch commit => has-screenshots has-patch
     needs-testing
 * focuses:  ui, css => ui, css, administration


Comment:

 Thanks @afercia I appreciate the overview and whole-heartedly agree we
 should avoid case-by-case adjustments here. Let's leave the button size
 and alignment items to the associated tickets (#48531 & #48420) where a
 proper decision and action can be taken for those inconsistencies. For
 this specific bug the patch @audrasjb provided
 ([https://core.trac.wordpress.org/attachment/ticket/49576/49576.1.diff
 49576.1.diff]) still applies properly but only resolved the issue for one
 breakpoint and didn't account for it breaking between x and y.

 I looked to expand the media query but also found string length due to
 locale comes into account too and almost ended up with the query applying
 to most desktop. Attempting just reducing the input width worked without
 the media query but didn't work when testing with longer string locales
 like Armenian.

 In [https://core.trac.wordpress.org/attachment/ticket/49576/49576.alt.diff
 49576.alt.diff] I found an alternate solution using margins to give the
 input and button their own space regardless of their proximity or the
 length of the locale string.

 This approach seems to work nicely and would love input from the team. If
 we're all on board let's apply this fix for this specific issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49576#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list