[wp-trac] [WordPress Trac] #47656: Remove 'Error:' prefixes from error notices as they're redundant

WordPress Trac noreply at wordpress.org
Mon Jun 15 15:38:28 UTC 2020


#47656: Remove 'Error:' prefixes from error notices as they're redundant
-------------------------+-------------------------------------------------
 Reporter:  garrett-     |       Owner:  audrasjb
  eclipse                |
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  5.5
Component:  I18N         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, accessibility, administration,
                         |  ui-copy
-------------------------+-------------------------------------------------
Changes (by afercia):

 * keywords:  has-patch commit => has-patch


Comment:

 Thanks for the refresh. Some issues in the latest patch:

 - I don't think files from external libraries should be changed, as they
 will be replaced with the next library updated. See
 `src/js/_enqueues/vendor/tinymce/langs/wp-langs-en.js`.
 - There's a reason why many strings use `’` instead of directly
 using the curly quote `’`. For example: `The email address isn’t
 correct.` should not be changed to `The email address isn’t correct`
 - Running `grunt precommit`, the
 `Tests_Ajax_ReplytoComment::test_with_draft_post` is failing because a
 string changed: `Failed asserting that exception message 'You can’t reply
 to a comment on a draft post.' contains 'You are replying to a comment on
 a draft post.'.`

 Will fix and commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47656#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list