[wp-trac] [WordPress Trac] #36455: Call opcache_reset() after plug-in, theme or core update
WordPress Trac
noreply at wordpress.org
Thu Jun 11 14:37:21 UTC 2020
#36455: Call opcache_reset() after plug-in, theme or core update
-------------------------------------------+---------------------------
Reporter: nigro.simone | Owner: mikeschroder
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.5
Component: Upgrade/Install | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing early | Focuses:
-------------------------------------------+---------------------------
Comment (by mikeschroder):
Okay! Working on a pass here.
Not quite done, but I said I'd review today, so I wanted to post an
update.
Currently, I'm liking a combination of the approaches a lot -- having a
filter available within a helper function, to allow hosts to do this in a
custom manner, and invalidating whether or not `revalidate_freq` is set,
to cover the case of a race condition before files are invalidated by PHP
automatically.
After a chat with @aaroncampbell, I'm not sure if it's necessary to
invalidate deleted files, since unless missing something, if the
new/modified files are invalidated properly, they should no longer
reference those deleted files.
I'm trying to think of cases where invalidating deleted files would be
important. Direct requests to them that are started from an already loaded
page (before the update), perhaps? Are there any common cases y'all have
seen?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36455#comment:81>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list