[wp-trac] [WordPress Trac] #50334: The Theme Installer displays an "Activate" button for the already active theme

[WordPress Trac]

#50334: The Theme Installer displays an "Activate" button for the already active
theme
--------------------------+-----------------------------
 Reporter:  afercia       |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Themes        |    Version:  4.6
 Severity:  normal        |   Keywords:  has-screenshots
  Focuses:                |
--------------------------+-----------------------------
 Noticed while investigating on #50316.

 In previous versions of WordPress, when navigating themes in the Theme
 Installer, the ''active'' theme displayed a ''visually'' disabled button
 (actually it's a `href="#"` link) with text "Installed". See first
 screenshot attached below.

 Starting from WordPress 4.6, this button (actually still a link) is a
 working link with text "Activate", which doesn't make much sense as the
 displayed theme is already the active one. See second screenshot attached
 below.

 Not sure if this change was intentional, but worth investigating. In any
 case, the "Activate" button/link is a bit misleading.

 To reproduce:
 - take note of the name of your currently active theme
 - go to the Add Themes page, located at `wp-admin/theme-
 install.php?browse=featured`
 - search for the name of your active theme
 - in the search results, click on "Details & Preview" on your active theme
 - the Theme Installer opens
 - observe the button/link at the top of the left sidebar and see the text
 says "Activate"
 - click the link
 - the theme installer opens and a notice appears on the page with the
 message "New theme activated. Visit site"

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50334>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform