[wp-trac] [WordPress Trac] #50316: Theme Install Page : Theme activate button not showing properly in a small device

[WordPress Trac]

#50316: Theme Install Page : Theme activate button not showing properly in a small
device
-------------------------------------+-------------------------------------
 Reporter:  pravinparmar2404         |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.5
Component:  Themes                   |     Version:  5.3.1
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug needs-    |     Focuses:  ui, css,
  patch                              |  administration
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  good-first-bug => good-first-bug needs-patch
 * version:  trunk => 5.3.1
 * milestone:  Awaiting Review => 5.5


Comment:

 Worth noting this happens in the Add Themes page (`wp-admin/theme-
 install.php`), not in the Customizer. I can reproduce the issue starting
 from WordPress 5.3.1.

 After the changes of the buttons and form controls CSS in WordPress 5.3
 and 5.3.1, the buttons now have a bigger height in the responsive view.
 The new CSS is also better standardized and removed several "exceptions".

 Unfortunately, this specific button lives in a "sticky" bar with a fixed
 height. Also, the button uses some CSS that is an "exception" to the
 default buttons style and doesn't fit with the changes from WP 5.3.

 Ideally, there shouldn't be exceptions. However, the Theme Installer top
 bar doesn't have a sufficient height to allow for the button height in the
 responsive view, which is now 40 pixels. It's a very similar case to the
 Customizer, which also has a fixed height top bar. These bars aren't
 responsive at all.

 Unfortunately, over the years, neither the Theme Installer and the
 Customizer fully addressed a solid implementation of a responsive view,
 togeher with other pars of the admin UI. To avoid a larger refactoring,
 I'd lean towards making this button not responsive as well, much like the
 similar button in the Customizer.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50316#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform