[wp-trac] [WordPress Trac] #49810: Remove workaround for $HTTP_RAW_POST_DATA bug present in PHP < 5.2.2

[WordPress Trac]

#49810: Remove workaround for $HTTP_RAW_POST_DATA bug present in PHP < 5.2.2
-------------------------------------------------+-------------------------
 Reporter:  skoskie                              |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  XML-RPC                              |     Version:  trunk
 Severity:  trivial                              |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:  rest-api
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by jrf):

 > If you were expecting that global to be backfilled, your code will
 break.

 Noone should ever have expected that though. The backfilling by WP in
 select places was only WP's way to mitigate the PHP BC-break when PHP 5.2
 still needed to be supported.

 > Do you no longer think that then?

 That's the only place where the variable is explicitely declared in the
 global namespace, which is why I made an exception.
 Removing the mitigation there would involve renaming the variable and
 introducing a new variable in the global namespace which is risky as well,
 which is why I left it as is, but yes, realistically, renaming that
 variable is on the table.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49810#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform